Discussion:
[fedfs-utils] [PATCH 0/3] Proposing fedfs-utils 0.10.6
Chuck Lever
2016-04-12 16:00:05 UTC
Permalink
The sixth maintenance release of fedfs-utils 0.10 addresses
some recent RPC header changes. It might be needed on systems
that have the very latest releases of glibc or libtirpc.

Review period ends at 11:59pm ET on Tuesday, April 19, 2016.

---

Chuck Lever (2):
fedfsd: libtirpc 1.0 moves the xp_auth field
Release 0.10.6

Thorsten Kukuk (1):
build: Fix hidden glibc header file dependency


README | 2 +-
configure.ac | 2 +-
src/fedfsd/gss.c | 4 ++++
src/libnsdb/Makefile.am | 2 +-
4 files changed, 7 insertions(+), 3 deletions(-)

--
Chuck Lever
Chuck Lever
2016-04-12 16:00:14 UTC
Permalink
svcauth_gss_get_principal() comes from the legacy U-M svc GSS
API, but is not documented, and does not appear in TI-RPC
headers. fedfs-utils 0.10 adopted this API to provide RPCGSS
support for the FedFS ADMIN protocol.

As a consequence of using an undocumented API, fedfs-utils
0.10 is exposed to library changes to this API. Add some
compatibility measures.

The fedfsd in fedfs-utils 0.11 replaces this call with a valid
contract API that does not expose SVCAUTH. Just a rebuild-relink
should take care of it there.

Signed-off-by: Chuck Lever <***@oracle.com>
---
src/fedfsd/gss.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/src/fedfsd/gss.c b/src/fedfsd/gss.c
index c63f42f..f762466 100644
--- a/src/fedfsd/gss.c
+++ b/src/fedfsd/gss.c
@@ -175,6 +175,10 @@ fedfsd_get_gss_cred(struct svc_req *rqstp)
{
SVCAUTH *auth;

+#if defined(SVC_XP_AUTH)
+ auth = &SVC_XP_AUTH(rqstp->rq_xprt);
+#else
auth = rqstp->rq_xprt->xp_auth;
+#endif
return svcauth_gss_get_principal(auth);
}
Chuck Lever
2016-04-12 16:00:24 UTC
Permalink
From: Thorsten Kukuk <***@suse.de>

In fedfs-utils, there is one place where no "-I/usr/include/tirpc" is
used. As result, glibc sunrpc header files are used instead of tirpc
ones.

You can see that nicely, if you install a glibc with deprecated-rpc
option enabled: fedfs-utils will fail to build because of missing
rpc header files.

Signed-off-by: Thorsten Kukuk <***@suse.de>
---
src/libnsdb/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libnsdb/Makefile.am b/src/libnsdb/Makefile.am
index 9387dba..c98d0e7 100644
--- a/src/libnsdb/Makefile.am
+++ b/src/libnsdb/Makefile.am
@@ -35,4 +35,4 @@ DISTCLEANFILES = Makefile.in
AM_CFLAGS = -ggdb -fstrict-aliasing \
-Wall -Wextra -pedantic -Wformat=2 \
-Wstrict-aliasing=2 -Wp,-D_FORTIFY_SOURCE=2
-AM_CPPFLAGS = -I. -I$(top_srcdir)/src/include
+AM_CPPFLAGS = -I. -I$(top_srcdir)/src/include -I/usr/include/tirpc
Chuck Lever
2016-04-12 16:00:33 UTC
Permalink
o Fix compatibility issues with newer libtirpc releases

Signed-off-by: Chuck Lever <***@oracle.com>
---
README | 2 +-
configure.ac | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/README b/README
index 65a1bb6..a9f24c6 100644
--- a/README
+++ b/README
@@ -9,7 +9,7 @@ SCM: git://git.linux-nfs.org/projects/cel/fedfs-utils.git
Bugzilla: https://oss.oracle.com/bugzilla


-Release notes for fedfs-utils 0.10.5
+Release notes for fedfs-utils 0.10.6


Release Quality Statement
diff --git a/configure.ac b/configure.ac
index 3232258..cab6d43 100644
--- a/configure.ac
+++ b/configure.ac
@@ -27,7 +27,7 @@
#

AC_PREREQ([2.65])
-AC_INIT([fedfs-utils], [0.10.5], [fedfs-utils-***@oss.oracle.com])
+AC_INIT([fedfs-utils], [0.10.6], [fedfs-utils-***@oss.oracle.com])
AC_CANONICAL_BUILD([])
AC_CONFIG_HEADERS([config.h])
AC_CONFIG_MACRO_DIR([m4])
Chuck Lever
2016-04-25 18:13:30 UTC
Permalink
Post by Chuck Lever
The sixth maintenance release of fedfs-utils 0.10 addresses
some recent RPC header changes. It might be needed on systems
that have the very latest releases of glibc or libtirpc.
Review period ends at 11:59pm ET on Tuesday, April 19, 2016.
Committed.
Post by Chuck Lever
---
fedfsd: libtirpc 1.0 moves the xp_auth field
Release 0.10.6
build: Fix hidden glibc header file dependency
README | 2 +-
configure.ac | 2 +-
src/fedfsd/gss.c | 4 ++++
src/libnsdb/Makefile.am | 2 +-
4 files changed, 7 insertions(+), 3 deletions(-)
--
Chuck Lever
_______________________________________________
fedfs-utils-devel mailing list
https://oss.oracle.com/mailman/listinfo/fedfs-utils-devel
--
Chuck Lever

Loading...